Skip to content

🐛 efs - deletion of data run in executor #7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 8, 2025
Merged

🐛 efs - deletion of data run in executor #7013

merged 6 commits into from
Jan 8, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jan 7, 2025 •
edited
Loading

What do these changes do?

  • 🐛 EFS Guardian - Data deletion is now executed within an executor to ensure it is a non-blocking operation.
  • 🐛 E2E - I initially thought the default Playwright timeout was 30 seconds, but it varies. For expect function, it was only 5 seconds, so I have overridden it to 30 seconds.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Jan 7, 2025
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jan 7, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review January 7, 2025 13:02
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing labels Jan 7, 2025
odeimaiz
odeimaiz approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sanderegg sanderegg mentioned this pull request Jan 7, 2025
Closed
GitHK
GitHK reviewed Jan 7, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (aca56c2) to head (0dc3045).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (aca56c2) and HEAD (0dc3045). Click for more details.

HEAD has 27 uploads less than BASE
Flag BASE (aca56c2) HEAD (0dc3045)
unittests 28 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7013       +/-   ##
===========================================
- Coverage   85.42%   67.79%   -17.63%     
===========================================
  Files        1598      686      -912     
  Lines       63099    32747    -30352     
  Branches     2041      262     -1779     
===========================================
- Hits        53901    22202    -31699     
- Misses       8862    10485     +1623     
+ Partials      336       60      -276
Flag Coverage Δ
integrationtests 64.86% <ø> (+0.04%) ⬆️
unittests 66.50% <100.00%> (-17.22%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.75% <ø> (-12.66%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian 90.12% <100.00%> (ø)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.21% <ø> (-20.47%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca56c2...0dc3045. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) January 7, 2025 14:16
pcrespov
pcrespov approved these changes Jan 7, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit a0bf53a into ITISFoundation:master Jan 8, 2025
88 of 93 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

a:efs-guardian bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

6 participants

@matusdrobuliak66 @giancarloromeo @GitHK @pcrespov @odeimaiz @sanderegg